-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
feat(profiling): add _process_vroomrs_transaction_profile #95223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat(profiling): add _process_vroomrs_transaction_profile #95223
Conversation
This adds the implementation for processing and ingesting transaction-profiles directly in the sentry celery task with the support of vroomrs. Similarly to what we already do with continuous profiles.
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
❌ Your patch check has failed because the patch coverage (8.57%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #95223 +/- ##
===========================================
+ Coverage 52.80% 87.94% +35.14%
===========================================
Files 10445 10464 +19
Lines 604240 605287 +1047
Branches 23617 23617
===========================================
+ Hits 319048 532312 +213264
+ Misses 284831 72614 -212217
Partials 361 361 |
🚨 BugBot couldn't runSomething went wrong. Try again by commenting "bugbot run", or contact support (requestId: serverGenReqId_33e56426-4eb1-4731-8765-2bef786a51f9). |
if "profiler_id" in profile: | ||
if _process_vroomrs_chunk_profile(profile): | ||
return True | ||
else: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we be explicit here and check that this is a transaction profile
This adds the implementation for processing and ingesting transaction-profiles directly in the sentry celery task with the support of vroomrs.
Similarly to what we already do with continuous profiles.