Skip to content

feat(profiling): add _process_vroomrs_transaction_profile #95223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

viglia
Copy link
Contributor

@viglia viglia commented Jul 10, 2025

This adds the implementation for processing and ingesting transaction-profiles directly in the sentry celery task with the support of vroomrs.

Similarly to what we already do with continuous profiles.

This adds the implementation for processing and ingesting
transaction-profiles directly in the sentry celery task with the support
of vroomrs.

Similarly to what we already do with continuous profiles.
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jul 10, 2025
Copy link

codecov bot commented Jul 10, 2025

Codecov Report

Attention: Patch coverage is 8.57143% with 64 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/profiles/task.py 7.24% 64 Missing ⚠️

❌ Your patch check has failed because the patch coverage (8.57%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #95223       +/-   ##
===========================================
+ Coverage   52.80%   87.94%   +35.14%     
===========================================
  Files       10445    10464       +19     
  Lines      604240   605287     +1047     
  Branches    23617    23617               
===========================================
+ Hits       319048   532312   +213264     
+ Misses     284831    72614   -212217     
  Partials      361      361               

@viglia viglia marked this pull request as ready for review July 10, 2025 14:30
@viglia viglia requested review from a team as code owners July 10, 2025 14:30
Copy link

cursor bot commented Jul 10, 2025

🚨 BugBot couldn't run

Something went wrong. Try again by commenting "bugbot run", or contact support (requestId: serverGenReqId_33e56426-4eb1-4731-8765-2bef786a51f9).

cursor[bot]

This comment was marked as off-topic.

if "profiler_id" in profile:
if _process_vroomrs_chunk_profile(profile):
return True
else:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we be explicit here and check that this is a transaction profile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants